Move PowerSyncKotlin/ to internal/#275
Merged
Merged
Conversation
stevensJourney
left a comment
stevensJourney
left a comment
Contributor
There was a problem hiding this comment.
I think we'd still need to update the deploy.yml actions for this new structure?
Contributor
Author
|
Good catch, thanks! Done. |
stevensJourney
approved these changes
Sep 30, 2025
stevensJourney
left a comment
stevensJourney
left a comment
Contributor
There was a problem hiding this comment.
Happy with this. This is much nicer than the previous structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a directory named
PowerSyncKotlin/in the root of the repository is somewhat confusing: It makes it sounds like that's where the PowerSync Kotlin SDK is, when in reality it's mostly unrelated to the Kotlin SDK.Since we've recently introduced the
internal/folder for another subproject, that sounds like a good place to put the Swift SDK helper to tidy up the workspace a bit.